[Svn-src-all:1269] [version-2_5-dev 20158] LC_Page_Mypage_DownLoad リファクタリング

[kimoto]

Subversion committed to /home/svn/open 20158
http://svn.ec-cube.net/open_trac/changeset/20158
┌────────────────────────────┐
│更新者　:  kimoto                                       │
│更新日時:  2011-02-12 19:44:40 +0900 (土, 12  2月 2011)│
└────────────────────────────┘

Log:
--------------------------------------------------------
LC_Page_Mypage_DownLoad リファクタリング
* sendResponseが特殊すぎる為そこは触っていません


Changed:                      [U:修正，A:追加，D:削除]
--------------------------------------------------------
U   branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php

変更: branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php
===================================================================
--- branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php	2011-02-12 10:01:59 UTC (rev 20157)
+++ branches/version-2_5-dev/data/class/pages/mypage/LC_Page_Mypage_DownLoad.php	2011-02-12 10:44:40 UTC (rev 20158)
@@ -75,12 +75,12 @@
         }
 
         // パラメータチェック
-        $this->objFormParam = new SC_FormParam();
-        $this->lfInitParam();
+        $objFormParam = new SC_FormParam();
+        $this->lfInitParam($objFormParam);
         // GET、SESSION['customer']値の取得
-        $this->objFormParam->setParam($_SESSION['customer']);
-        $this->objFormParam->setParam($_GET);
-        $this->arrErr = $this->lfCheckError();
+        $objFormParam->setParam($_SESSION['customer']);
+        $objFormParam->setParam($_GET);
+        $this->arrErr = $this->lfCheckError($objFormParam);
         if (count($this->arrErr)!=0){
             SC_Utils_Ex::sfDispSiteError(DOWNFILE_NOT_FOUND,"",true);
         }
@@ -88,6 +88,8 @@
 
     /**
      * Page のResponse.
+     *
+     * todo たいした処理でないのに異常に処理が重い
      * @return void
      */
     function sendResponse() {
@@ -190,19 +192,17 @@
 
 
     /* パラメータ情報の初期化 */
-    function lfInitParam() {
-        $this->objFormParam->addParam("customer_id", "customer_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
-        $this->objFormParam->addParam("order_id", "order_id", INT_LEN, "n", array("EXIST_CHECK", "NUM_CHECK"));
-        $this->objFormParam->addParam("product_id", "product_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
-        $this->objFormParam->addParam("product_class_id", "product_class_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+    function lfInitParam(&$objFormParam) {
+        $objFormParam->addParam("customer_id", "customer_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+        $objFormParam->addParam("order_id", "order_id", INT_LEN, "n", array("EXIST_CHECK", "NUM_CHECK"));
+        $objFormParam->addParam("product_id", "product_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
+        $objFormParam->addParam("product_class_id", "product_class_id", INT_LEN, "n", array("EXIST_CHECK","NUM_CHECK"));
     }
 
     /* 入力内容のチェック */
-    function lfCheckError() {
-        // 入力データを渡す。
-        $arrRet = $this->objFormParam->getHashArray();
-        $objErr = new SC_CheckError($arrRet);
-        $objErr->arrErr = $this->objFormParam->checkError();
+    function lfCheckError(&$objFormParam) {
+        $objErr = new SC_CheckError($objFormParam->getHashArray());
+        $objErr->arrErr = $objFormParam->checkError();
         return $objErr->arrErr;
     }