[Svn-src-all:1334] [version-2_5-dev 20223] ボスの周辺にいる雑魚の退治的なリファクタリング。ちょろいなフフ。

[miningbrownie]

Subversion committed to /home/svn/open 20223
http://svn.ec-cube.net/open_trac/changeset/20223
┌────────────────────────────┐
│更新者　:  miningbrownie                                │
│更新日時:  2011-02-20 02:45:48 +0900 (日, 20  2月 2011)│
└────────────────────────────┘

Log:
--------------------------------------------------------
ボスの周辺にいる雑魚の退治的なリファクタリング。ちょろいなフフ。

Changed:                      [U:修正，A:追加，D:削除]
--------------------------------------------------------
U   branches/version-2_5-dev/data/class/pages/admin/order/LC_Page_Admin_Order_MailView.php

変更: branches/version-2_5-dev/data/class/pages/admin/order/LC_Page_Admin_Order_MailView.php
===================================================================
--- branches/version-2_5-dev/data/class/pages/admin/order/LC_Page_Admin_Order_MailView.php	2011-02-19 17:39:51 UTC (rev 20222)
+++ branches/version-2_5-dev/data/class/pages/admin/order/LC_Page_Admin_Order_MailView.php	2011-02-19 17:45:48 UTC (rev 20223)
@@ -63,20 +63,29 @@
      * @return void
      */
     function action() {
+        $send_id = $_GET['send_id'];
         // 認証可否の判定
         SC_Utils_Ex::sfIsSuccess(new SC_Session());
-
-        if(SC_Utils_Ex::sfIsInt($_GET['send_id'])) {
-            $objQuery =& SC_Query::getSingletonInstance();
-            $col = "subject, mail_body";
-            $where = "send_id = ?";
-            $arrRet = $objQuery->select($col, "dtb_mail_history", $where, array($_GET['send_id']));
-            $this->tpl_subject = $arrRet[0]['subject'];
-            $this->tpl_body = $arrRet[0]['mail_body'];
+        if(SC_Utils_Ex::sfIsInt($send_id)) {
+            $mailHistory = $this->getMailHistory($send_id);
+            $this->tpl_subject = $mailHistory[0]['subject'];
+            $this->tpl_body = $mailHistory[0]['mail_body'];
         }
         $this->setTemplate($this->tpl_mainpage);
     }
 
+    /**
+     * 
+     * メールの履歴を取り出す。
+     * @param int $send_id
+     */
+    function getMailHistory($send_id){
+        $objQuery =& SC_Query::getSingletonInstance();
+        $col = "subject, mail_body";
+        $where = "send_id = ?";
+        $mailHistory = $objQuery->select($col, "dtb_mail_history", $where, array($send_id));
+        return $mailHistory;
+    }
 
 
     /**